Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(BA-626): Move abc.py and storage system modules to volumes package (#3563) #3567

Open
wants to merge 8 commits into
base: refactor/apply-decorator
Choose a base branch
from
Open

refactor(BA-626): Move abc.py and storage system modules to volumes package (#3563) #3567

wants to merge 8 commits into from
+117 −91

Conversation

MintCat98
Copy link

@MintCat98 MintCat98 commented Feb 3, 2025 •
edited by github-actions bot
Loading

resolves #3563 (BA-626)

New package: volumes

  • BUILD (added)
  • abc.py (moved)
  • cephfs (moved)
  • ddn (moved)
  • dellemc (moved)
  • gpfs (moved)
  • netapp (moved)
  • purestroage (moved)
  • vast (moved)
  • vfs (moved)
  • weka (moved)
  • xfs (moved)

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Mention to the original issue
  • Installer updates including:
    • Fixtures for db schema changes
    • New mandatory config options
  • Update of end-to-end CLI integration tests in ai.backend.test
  • API server-client counterparts (e.g., manager API -> client SDK)
  • Test case(s) to:
    • Demonstrate the difference of before/after
    • Demonstrate the flow of abstract/conceptual models with a concrete implementation
  • Documentation
    • Contents in the docs directory
    • docstrings in public interfaces and type annotations

📚 Documentation preview 📚: https://sorna--3567.org.readthedocs.build/en/3567/

📚 Documentation preview 📚: https://sorna-ko--3567.org.readthedocs.build/ko/3567/

@github-actions github-actions bot added area:docs Documentations comp:common Related to Common component comp:storage-proxy Related to Storage proxy component size:XL 500~ LoC labels Feb 3, 2025
@MintCat98 MintCat98 changed the base branch from main to refactor/apply-decorator February 4, 2025 01:44
HyeockJinKim
HyeockJinKim approved these changes Feb 4, 2025
View reviewed changes
Copy link
Collaborator

@HyeockJinKim HyeockJinKim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions github-actions bot added size:L 100~500 LoC and removed size:XL 500~ LoC labels Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HyeockJinKim HyeockJinKim HyeockJinKim approved these changes

Assignees

@MintCat98 MintCat98

Labels
area:docs Documentations comp:common Related to Common component comp:storage-proxy Related to Storage proxy component size:L 100~500 LoC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move abc.py and storage system modules to volumes package
2 participants
@MintCat98 @HyeockJinKim